Skip to content

feat: add codespell for markdown spell checking - #148

Merged
r2dedios merged 3 commits into
RHEcosystemAppEng:mainfrom
TomerFi:feat/codespell
Jul 27, 2026
Merged

feat: add codespell for markdown spell checking#148
r2dedios merged 3 commits into
RHEcosystemAppEng:mainfrom
TomerFi:feat/codespell

Conversation

@TomerFi

@TomerFi TomerFi commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Add codespell as a spell checker for catching typos in skill files, flow files, and documentation
  • Pre-commit hook, make validate-spelling target, and CI workflow
  • Ignore list for project-specific terms (cna, te, pre-select)

Notes

  • CI workflow pins actions/checkout to v4.2.1 to match existing workflows. A bump to v7 across all workflows can be done separately.
  • codespell reads config from .codespellrc automatically (both pre-commit and CI)

Closes #145

Add codespell as a spell checker for catching typos in skill files,
flow files, and documentation. Includes pre-commit hook, Makefile
target (validate-spelling), and CI workflow.

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>

@ikrispin ikrispin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!
From what I've checked there might be only one issue - codespell-project/actions-codespell@v2.1 defaults skip to ./.git and always passes --skip on the CLI and treats CLI flags as overrides of the config file, so I think the CI ends up ignoring the skip list in .codespellrc (*.json, dist, etc.). This way local and CI can diverge.

Possible fixes could be either pass the same skip / ignore_words_file via the action with: block, or run uv run codespell in CI so it picks up .codespellrc the same way as make validate-spelling?

@r2dedios r2dedios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Comment thread Makefile
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
@TomerFi

TomerFi commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

@ikrispin Great catch! Fixed in a914534.

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>

@r2dedios r2dedios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@r2dedios
r2dedios merged commit 2eb10e3 into RHEcosystemAppEng:main Jul 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add codespell for markdown spell checking

3 participants